Decorate Spree::UsersController when already existing from Solidus Frontend
#206
Conversation
This commit allows to decorate the class `Spree::UsersController` when already present (ie. when it's already included in the gem `solidus_frontend`) or to define the class from scratch when it's not (ie. when using a version of Solidus where `solidus_frontend` does not include it). See solidusio/solidus#2695 for the PR that adds the account page to Solidus Frontend. Once all supported versions of Solidus include the account page, we will be able to get rid of the class definition, together with the ERB view at `lib/views/frontend/spree/users/show.html.erb`.
spaghetticode
force-pushed
the
spaghetticode/remove-account-page
branch
from
22a99a3
to
8da3e8e
Compare
| if defined?(Spree::UsersController) | ||
| Spree::UsersController.prepend(self) | ||
| else | ||
| class Spree::UsersController < Spree::StoreController |
There was a problem hiding this comment.
@spaghetticode What about keeping the controller in the past directory and duplicating the ifs? I'm just thinking that people may expect to look for this controller in that folder and not finding it. On the other side, I understand that the controller code will be split into two different files and people can't know that this file exists. Well, unless we tell them with a code comment! 😬
What do you think?
There was a problem hiding this comment.
Would that work with Zeitwerk?
There was a problem hiding this comment.
I think it does, I was more worried about this version to be honest. With what I proposed, we'll have Spree::UsersController class defined into lib/controllers/frontend/spree/users_controller.rb.
Ref #123
With solidusio/solidus#2695 we're starting to include the order history page (
/users/show) in Solidus frontend. At the moment that code is not used, since the one included insolidus_auth_devisetakes precedence.This PR starts the removal of the controller code so that, when available, the version included in Solidus at
frontend/app/controllers/spree/users_controller.rbis used instead.Once all supported versions of Solidus include that page, we will be able to get rid of the
elsebranch with the class definition, together with the ERB view atlib/views/frontend/spree/users/show.html.erb.