Extension maintenance #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Performance cops are deprecated, this is the new standard way of including those cops. Updating Rubocop, it also requires to update the target ruby version.
Now that we require Ruby >= 2.3 we can safely use it.
And fix all the issues reported: - use safe navigation instead of try - avoid deprecated update_attributes - avoid update_column - avoid dynamic find_by_something - use delegate when possible - use Time with zone I also had to exclude the Rails/Output cop from the seed file since we need to use puts there.
spaghetticode
approved these changes
Jul 18, 2019
jacobherrington
approved these changes
Jul 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes two things:
Move rubocop performance cops
This is needed after rubocop/rubocop#5977.
We also need to update the required Ruby version to 2.3 to accommodate the
rubocopgem update, required byrubocop-performance.Add rubocop-rails cops
It provided some useful suggestions which have been fixed within this same PR.