Move shipping promotion handling to legacy promotions #5753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With a properly configured promotion system, we don't need a special "shipping" promotion handler. This moves the shipping-specific promotion handling into the solidus_legacy_promotions gem.
The new promotion system does not distinguish between shipping promotions and other promotions, and there is no need for a dedicated shipping promotion handler class in the public API for the promotion configuration. Deprecate it.
github-actions
bot
added
changelog:solidus_core
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5753 +/- ##
=======================================
Coverage 88.85% 88.85%
=======================================
Files 706 707 +1
Lines 16781 16789 +8
=======================================
+ Hits 14910 14918 +8
Misses 1871 1871 ☔ View full report in Codecov by Sentry. |
tvdeyen
approved these changes
May 17, 2024
adammathys
approved these changes
May 17, 2024
kennyadsl
approved these changes
May 21, 2024
| def self.prepended(base) | ||
| base.state_machine do | ||
| if states[:delivery] | ||
| before_transition from: :delivery, do: :apply_shipping_promotions |
There was a problem hiding this comment.
This could be formally breaking if someone replaced their whole state machine and removed this transition. But, I think it's acceptable because if that store doesn't use shipping promotions there won't be any change, and if they use it, it will just be recalculated twice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We should only provide configuration points that are actually necessary for a promotion system. The shipping promotion handler is not necessary for a promotion system that works, thus we can move this stuff to the
legacy_promotionsextension.Extracted from #5634
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: