Rename Spree::Config.promotions.promotion_adjuster_class #5752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
changelog:solidus_core
mamhoff
force-pushed
the
rename-adjuster-class
branch
from
f241753
to
30b9174
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5752 +/- ##
==========================================
- Coverage 88.85% 88.84% -0.01%
==========================================
Files 706 706
Lines 16781 16784 +3
==========================================
+ Hits 14910 14912 +2
- Misses 1871 1872 +1 ☔ View full report in Codecov by Sentry. |
adammathys
reviewed
May 16, 2024
This extension point has duplication when used, so we're renaming it to `Spree::Config.promotions.order_adjuster_class`. This describes better what it does.
mamhoff
force-pushed
the
rename-adjuster-class
branch
from
30b9174
to
1c7f5f0
Compare
adammathys
approved these changes
May 16, 2024
kennyadsl
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This extension point has duplication when used, so we're renaming it to
Spree::Config.promotions.order_adjuster_class. This describes better what it does.The new promotions configuration class has not been released, so we don't need a deprecation cycle for this change.
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs: