Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix detecting exec js version by adding minimal requirement for autoprefixer-rails #4077

Merged

Conversation

waiting-for-dev
Copy link
Contributor

Fixes #4055

Checklist:

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have updated Guides and README accordingly to this change (if needed)
  • I have added tests to cover this change (if needed)
  • I have attached screenshots to this PR for visual changes (if needed)

@kennyadsl
Copy link
Member

How does this play with #4072? Are they supposed to be alternative PRs or do we need both?

@waiting-for-dev
Copy link
Contributor Author

How does this play with #4072? Are they supposed to be alternative PRs or do we need both?

They are independent and only tangentially related:

  • execjs released a new version compatible with ruby 3
  • The new version broke autoprefixer-rails
  • autoprefixer-rails released a new version locking to the old execjs version (remember, not compatible with ruby 3)
  • autoprefixer-rails released another new version fixing the issue for both 3 >= ruby < 3
  • This issue makes the last autoprefixer-rails release the minimal version to use
  • Support Ruby 3 #4072 makes solidus compatible with ruby 3

Copy link
Member

@kennyadsl kennyadsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thanks for the detailed clarification!

Copy link
Member

@spaghetticode spaghetticode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kennyadsl kennyadsl merged commit 4ae48a3 into solidusio:master May 26, 2021
@kennyadsl kennyadsl deleted the waiting-for-dev/autoprefixer_issue branch May 26, 2021 14:36
@kennyadsl kennyadsl added the changelog:solidus_core Changes to the solidus_core gem label May 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:solidus_core Changes to the solidus_core gem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError: Cannot read property 'version' of undefined
3 participants