Add support for Sprockets v4 to the DummyApp #3379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvdeyen
approved these changes
Oct 11, 2019
core/lib/spree/testing_support/dummy_app/assets/config/manifest.js
Outdated
Show resolved
Hide resolved
| @@ -87,6 +87,7 @@ class Application < ::Rails::Application | |||
| config.action_controller.include_all_helpers = false | |||
|
|
|||
| if config.respond_to?(:assets) | |||
| config.assets.config_manifest = File.expand_path('dummy_app/assets/config/manifest.js', __dir__) | |||
4 tasks
kennyadsl
force-pushed
the
kennyadsl/sprockets-4-support
branch
from
9789abc
to
cc5a4f5
Compare
kennyadsl
added
the
release:major
waiting-for-dev
removed
the
release:major
elia
force-pushed
the
kennyadsl/sprockets-4-support
branch
from
cc5a4f5
to
2fbe9c3
Compare
elia
force-pushed
the
kennyadsl/sprockets-4-support
branch
from
2fbe9c3
to
c719179
Compare
elia
force-pushed
the
kennyadsl/sprockets-4-support
branch
2 times, most recently
from
8163a5f
to
4024df7
Compare
github-actions
bot
added
the
changelog:repository
elia
removed
changelog:solidus_core
This is needed from Sprockets, since v4. It contains all dependencies that needs to be compiled. Co-Authored-By: Elia Schito <elia@schito.me>
elia
force-pushed
the
kennyadsl/sprockets-4-support
branch
from
4024df7
to
1a35ea5
Compare
github-actions
bot
added
the
changelog:solidus_core
Removing the dependency on sprockets < 4 rack is now unbounded, but rack 3 is only supported from Rails 7.1 up.
elia
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃洃 BLOCKED BY rails/sprockets-rails#446Description
Sprockets 4 introduced a mandatory configuration manifest at a specific location. We don't have the ability to set it at that specific location in the DummyApp we use for our specs.
I've opened rails/sprockets-rails#446 on sprockets-rails which should fix this issue. I'll leave this PR open (working with that branch) waiting to know if that PR will be accepted.Update: Now an empty manifest will be written in the expected location inside
spec/dummyduring the dummy app setup.Closes #3374, closes #3376
After merging this we need to revertThis also reverts #3378.Checklist: