Ensure @relation_types is assigned before #update
#97
Conversation
|
It looks like the recent |
benjaminwil
force-pushed
the
benjaminwil/fix-variants-controller-update-action
branch
3 times, most recently
from
c110a71
to
cd7f911
Compare
|
@benjaminwil looks like we're all good now! Can you update/remove your last commit? |
benjaminwil
force-pushed
the
benjaminwil/fix-variants-controller-update-action
branch
2 times, most recently
from
ae00cf6
to
05a3316
Compare
|
@aldesantis When I removed my commit, the tests re-broke again. I know that we don't actually want to change any explicit dependencies in the gemspec here, so I'm not sure how to proceed. 🤔 Sorry. |
|
@benjaminwil actually, let's add that back in. I hadn't investigated the issue thoroughly, but it sounds like the only way forward is to upgrade the version of autoprefixer-rails. Sorry for the confusion! |
|
I opened #98 so that I could better describe why I was making the change. We can merge this after that one! |
|
@benjaminwil I merged your other PR, could you rebase? 🙏 |
When the admin variants controller cannot successfully complete an `#update` action, it re-renders the user back on the `#edit` action view. This causes `@relation_types` to be nil and makes the Deface template that tries to load product relations error out on a `@relation_types.empty?` block. We can avoid this by making sure this before action is performed on `#update`, too. Co-Authored-By: Adam Mueller <adam@super.gd>
benjaminwil
force-pushed
the
benjaminwil/fix-variants-controller-update-action
branch
from
05a3316
to
a11f8f3
Compare
|
Rebased! |
|
@benjaminwil thank you so much! |
When the admin variants controller cannot successfully complete an
#updateaction, it re-renders the user back on the#editactionview.
This causes
@relation_typesto be nil and makes the Deface templatethat tries to load product relations error out on a
@relation_types.empty?block.We can avoid this by just making sure this before action is performed on
#update, too.