Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solid v1.8 #1909

Merged
merged 14 commits into from
Oct 9, 2023
Merged

Solid v1.8 #1909

merged 14 commits into from
Oct 9, 2023

Conversation

ryansolid
Copy link
Member

This is PR for Solid 1.8. Mostly changes around SSR and serialization. See changelog for full details.

@changeset-bot
Copy link

changeset-bot bot commented Oct 9, 2023

🦋 Changeset detected

Latest commit: fc64240

The changes in this PR will be included in the next version bump.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link

github-actions bot commented Oct 9, 2023

Pull Request Test Coverage Report for Build 6462462984

  • 9 of 19 (47.37%) changed or added relevant lines in 4 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.02%) to 93.545%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/solid/src/reactive/signal.ts 5 7 71.43%
packages/solid/src/render/Suspense.ts 0 8 0.0%
Files with Coverage Reduction New Missed Lines %
packages/solid/src/reactive/signal.ts 1 93.24%
Totals Coverage Status
Change from base Build 6226847719: 0.02%
Covered Lines: 4143
Relevant Lines: 4360

💛 - Coveralls

@ryansolid ryansolid merged commit 2c087cb into main Oct 9, 2023
1 check passed
@coveralls
Copy link

coveralls commented May 22, 2024

Pull Request Test Coverage Report for Build 6462424414

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 9 of 19 (47.37%) changed or added relevant lines in 4 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.02%) to 93.545%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/solid/src/reactive/signal.ts 5 7 71.43%
packages/solid/src/render/Suspense.ts 0 8 0.0%
Files with Coverage Reduction New Missed Lines %
packages/solid/src/reactive/signal.ts 1 93.24%
Totals Coverage Status
Change from base Build 6226847719: 0.02%
Covered Lines: 4143
Relevant Lines: 4360

💛 - Coveralls

1 similar comment
@coveralls
Copy link

Pull Request Test Coverage Report for Build 6462424414

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 9 of 19 (47.37%) changed or added relevant lines in 4 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.02%) to 93.545%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/solid/src/reactive/signal.ts 5 7 71.43%
packages/solid/src/render/Suspense.ts 0 8 0.0%
Files with Coverage Reduction New Missed Lines %
packages/solid/src/reactive/signal.ts 1 93.24%
Totals Coverage Status
Change from base Build 6226847719: 0.02%
Covered Lines: 4143
Relevant Lines: 4360

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants