Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: createServerValue #1889

Open
wants to merge 5 commits into
base: next
Choose a base branch
from
Open

Conversation

lxsmnsyc
Copy link
Member

@lxsmnsyc lxsmnsyc commented Sep 23, 2023

Summary

This is a PoC for exploring the new serialization method. This PR adds a new primitive called createServerValue which allows users to instanciate server-side values and load those exact values on hydration. This is like resumability for babies.

A great use case of this would be:

// Without createServerValue, this will throw a hydration error 99.9% of the time.
const someRandomData = createServerValue(() => Math.random());

return <h1>Data: {someRandomData}</h1>;

By default, createServerValue should be able to serialize everything the createResource is capable of (as of course they share the same serializer), with the exception of createServerValue having non-blocking serialization assuming that it produces a Promise. This is, of course, is up for debate.

This might also be in conflict with the upcoming async primitive.

How did you test this change?

@changeset-bot
Copy link

changeset-bot bot commented Sep 23, 2023

⚠️ No Changeset found

Latest commit: cce4056

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

export function createServerValue<T>(cb: () => T): T {
const ctx = sharedConfig.context;
// This might be fun specially if the value is a Promise
// but of course, the only way they can translate the Promise

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what do you mean by "translte the Promise"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

convert the Promise into something the components and the reactivity system can understand

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants