Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: rename property reload to load in lazy component #1859

Closed
wants to merge 2 commits into from

Conversation

wjq990112
Copy link
Contributor

Summary

Rename preload to load in lazy method's return value

In this PR:

  • The preload property from the lazy method's return value has been renamed to load.
  • To ensure backward compatibility with existing project, the preload property has been deprecated but not removed. Developers are encouraged to use the new load property going forward.

It's recommended for all teams and developers to start transitioning to the use of load as preload may be removed in future releases.

Close #1726.

How did you test this change?

None.

@changeset-bot
Copy link

changeset-bot bot commented Aug 17, 2023

⚠️ No Changeset found

Latest commit: 14bb190

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ryansolid
Copy link
Member

Not going to do this one.

@ryansolid ryansolid closed this Nov 22, 2023
@coveralls
Copy link

Pull Request Test Coverage Report for Build 5886872898

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 15 of 15 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 93.632%

Totals Coverage Status
Change from base Build 5825024461: 0.01%
Covered Lines: 4146
Relevant Lines: 4363

💛 - Coveralls

1 similar comment
@coveralls
Copy link

coveralls commented May 22, 2024

Pull Request Test Coverage Report for Build 5886872898

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 15 of 15 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 93.632%

Totals Coverage Status
Change from base Build 5825024461: 0.01%
Covered Lines: 4146
Relevant Lines: 4363

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename preload method to load in lazy
3 participants