Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stores: fix overwriting underscore property #1842

Merged
merged 2 commits into from
Aug 8, 2023

Conversation

morethanwords
Copy link
Contributor

Summary

Store doesn't handle _ property well. It works fine when adding element first time, but when you try to modify the same element, property will be undefined.

How did you test this change?

pnpm t

@changeset-bot
Copy link

changeset-bot bot commented Aug 4, 2023

🦋 Changeset detected

Latest commit: 26b1d48

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
solid-js Patch
test-integration Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@morethanwords morethanwords changed the title Fix underscore property Stores: fix overwriting underscore property Aug 4, 2023
@ryansolid ryansolid merged commit c2008f0 into solidjs:main Aug 8, 2023
1 check passed
@ryansolid
Copy link
Member

Thank you.

@coveralls
Copy link

coveralls commented May 22, 2024

Pull Request Test Coverage Report for Build 5800790021

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.003%) to 93.913%

Files with Coverage Reduction New Missed Lines %
packages/solid/src/index.ts 1 97.87%
Totals Coverage Status
Change from base Build 5756852867: 0.003%
Covered Lines: 4142
Relevant Lines: 4343

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants