Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Owner.sourceMap is not cleaned when the computation reruns #1024

Closed
otonashixav opened this issue May 30, 2022 · 0 comments
Closed

Owner.sourceMap is not cleaned when the computation reruns #1024

otonashixav opened this issue May 30, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@otonashixav
Copy link
Contributor

Issue: Owner.sourceMap is not cleaned when the computation reruns, causing signals created during previous runs to persist.

Reproduction: https://codesandbox.io/s/blissful-meadow-gu9not?file=/src/main.tsx

Expected: Owner.sourceMap should not contain signals created during previous runs of the computation.

cleanNode should set sourceMap to undefined or delete it here: https://github.com/solidjs/solid/blob/main/packages/solid/src/reactive/signal.ts#L1579
@ryansolid ryansolid added the bug Something isn't working label Jun 1, 2022
@thetarnav thetarnav mentioned this issue Jun 13, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ryansolid @otonashixav