Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better support for HMR #9

Closed
thetarnav opened this issue May 29, 2022 · 0 comments · Fixed by #10
Closed

Better support for HMR #9

thetarnav opened this issue May 29, 2022 · 0 comments · Fixed by #10
Labels
bug Something isn't working solid Changes to solid are required

Comments

@thetarnav
Copy link
Owner

thetarnav commented May 29, 2022

Currently, the debugger and the devtools panel don't account for HMR.
I don't know how far the possible errors can go, but one noticeable behavior is that existing signals are duplicated — new signal objects are probably created during the refresh. And the reconciler doesn't allow for existing signals to be removed (I don't think it's possible).

One solution could be to just force update the whole graph on refresh and don't reconcile it — treat it as a fresh one. But how to know when the HMR happened?

Or try to reconcile new signal objects during waking the owner tree in the debugger. What the solid-refresh/vite does to the graph?

Edit: apparently this was caused by Solid not cleaning sourceMap property computation rerun. (fixed by solidjs/solid#1024)

@thetarnav thetarnav added the bug Something isn't working label May 29, 2022
thetarnav added a commit that referenced this issue May 31, 2022
@thetarnav thetarnav added the solid Changes to solid are required label Jun 13, 2022
thetarnav added a commit that referenced this issue Jun 13, 2022
not needed after solid-js@1.4.4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working solid Changes to solid are required
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant