docs: add faq section #993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yoezlem
approved these changes
May 2, 2024
mariohamann
reviewed
May 3, 2024
coraliefeil
reviewed
May 3, 2024
coraliefeil
reviewed
May 3, 2024
coraliefeil
reviewed
May 3, 2024
coraliefeil
reviewed
May 3, 2024
coraliefeil
reviewed
May 3, 2024
coraliefeil
reviewed
May 3, 2024
|
@mariohamann / @coraliefeil pushed some changes and re-assigned you. |
|
@coraliefeil / @mariohamann I updated it. Pls re-review and / or resolve the open conversations. @mariohamann I installed my local setup and as usual I have some updates in the lock file. In addition, some checks are ❌ing caused by dependency installations. Any idea what I did wrong? |
|
Looks like a diverging version of |
coraliefeil
approved these changes
May 13, 2024
karlbaumhauer
changed the title
|
the has top and bottom margin which should be deleted. 
|
|
Could we add more vertical spacing between headline and accordion group, pls? |
|
@coraliefeil fixed both points. Pls let me know if its enough spacing now. |
|
Approved |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
adds a FAQ section to our documentation
closes https://github.com/solid-design-system/internal/issues/21
Definition of Reviewable: