Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: ✨ add sd-scrollable #966

Merged
merged 20 commits into from
May 22, 2024
Merged

feat: ✨ add sd-scrollable #966

merged 20 commits into from
May 22, 2024

Conversation

azraefendic
Copy link
Contributor

@azraefendic azraefendic commented Apr 19, 2024 •
edited

Description:

Added the sd-scrollable component.

Closes #289

Definition of Reviewable:

  • Documentation is created/updated
  • Migration Guide is created/updated
  • E2E tests (features, a11y, bug fixes) are created/updated
  • Stories (features, a11y) are created/updated
  • relevant tickets are linked

@azraefendic azraefendic self-assigned this Apr 19, 2024
@coraliefeil coraliefeil removed their assignment Apr 26, 2024
@van-nguyen-ht van-nguyen-ht removed their assignment Apr 29, 2024
@van-nguyen-ht
Copy link
Contributor

hey @azraefendic here's the screenshot for Mouseless story. When I move, the slot has this thin blue line before it goes to the button

Screenshot 2024-04-29 at 16 11 24

@azraefendic
Copy link
Contributor Author

Hey @van-nguyen-ht , I fixed the Mouseless story now.

yoezlem
yoezlem approved these changes May 2, 2024
View reviewed changes
Copy link
Contributor

@yoezlem yoezlem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx @azraefendic!

@yoezlem yoezlem removed their assignment May 2, 2024
@van-nguyen-ht
Copy link
Contributor

@azraefendic thank you Azra, I've accept the story :)

@van-nguyen-ht van-nguyen-ht removed their assignment May 3, 2024
karlbaumhauer
karlbaumhauer approved these changes May 3, 2024
View reviewed changes
Copy link
Contributor

@karlbaumhauer karlbaumhauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. THX @azraefendic

@karlbaumhauer karlbaumhauer removed their assignment May 3, 2024
@mariohamann mariohamann removed their assignment May 3, 2024
@mariohamann
Copy link
Contributor

Please re-assign when done with the changes.

@Vahid1919 Vahid1919 mentioned this pull request May 15, 2024
Merged
5 tasks
@Vahid1919 Vahid1919 removed their assignment May 16, 2024
@azraefendic azraefendic merged commit 3d7bcad into main May 22, 2024
11 checks passed
@azraefendic azraefendic deleted the feat/add-sd-scrollable branch May 22, 2024 20:26
karlbaumhauer pushed a commit that referenced this pull request May 22, 2024
@semantic-release-bot
chore(release/components): 3.4.0 [skip actions]
b235d50 
# [@solid-design-system/components-v3.4.0](components/3.3.1...components/3.4.0) (2024-05-22)

### Features

* ✨ add sd-scrollable ([#966](#966)) ([3d7bcad](3d7bcad)), closes [#289](#289)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karlbaumhauer karlbaumhauer karlbaumhauer approved these changes

@mariohamann mariohamann mariohamann approved these changes

@yoezlem yoezlem yoezlem approved these changes

Assignees

@mariohamann mariohamann

Labels
None yet
Projects
Solid Design System Project Board
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: ✨ add sd-scrollable
7 participants
@azraefendic @van-nguyen-ht @mariohamann @karlbaumhauer @yoezlem @coraliefeil @Vahid1919