Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add sd-prose (CSS Style) #930

Merged
merged 19 commits into from
May 29, 2024
Merged

feat: add sd-prose (CSS Style) #930

merged 19 commits into from
May 29, 2024

Conversation

mariohamann
Copy link
Contributor

@mariohamann mariohamann commented Apr 10, 2024

Description:

This PR adds the sd-prose CSS style. In addition it fixes and refactors sd-list, which had problems with mixed list types.

Definition of Reviewable:

PR notes: Irrelevant elements should be removed.

  • Documentation is created/updated
  • Migration Guide is created/updated
  • E2E tests (features, a11y, bug fixes) are created/updated
  • Stories (features, a11y) are created/updated
  • relevant tickets are linked

@mariohamann mariohamann marked this pull request as ready for review May 22, 2024 16:18
@mariohamann mariohamann changed the title feat: init sd-prose feat: add sd-prose (CSS Style) May 22, 2024
@mariohamann
Copy link
Contributor Author

mariohamann commented May 22, 2024

@yoezlem This is currently missing out migration guides. Would you be fine in moving this to a follow-up task, so that maybe someone else can take it over?

@coraliefeil I would like to talk with you about max-width and inverted of figcaption.

styleName: 'sd-prose',
summary: 'Prose',
status: 'stable',
since: '1.13',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Has to be fixed before merging.

packages/components/src/styles/prose/prose.stories.ts Outdated Show resolved Hide resolved
packages/components/src/styles/prose/prose.stories.ts Outdated Show resolved Hide resolved
@mariohamann mariohamann self-assigned this May 23, 2024
@yoezlem
Copy link
Contributor

yoezlem commented May 23, 2024

@yoezlem This is currently missing out migration guides. Would you be fine in moving this to a follow-up task, so that maybe someone else can take it over?

@coraliefeil I would like to talk with you about max-width and inverted of figcaption.

Alright, but please create a new ticket for the migration guide :)

@mariohamann
Copy link
Contributor Author

@yoezlem This is currently missing out migration guides. Would you be fine in moving this to a follow-up task, so that maybe someone else can take it over?
@coraliefeil I would like to talk with you about max-width and inverted of figcaption.

Alright, but please create a new ticket for the migration guide :)

Done!

#1115

@mariohamann mariohamann linked an issue May 23, 2024 that may be closed by this pull request
9 tasks
@coraliefeil coraliefeil removed their assignment May 24, 2024
@coraliefeil
Copy link
Contributor

Pls reassign for another review.

Copy link
Contributor

@Vahid1919 Vahid1919 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mariohamann
Copy link
Contributor Author

@coraliefeil
Copy link
Contributor

Approved. Thank you so much. <3

@mariohamann mariohamann merged commit b82d60f into main May 29, 2024
3 checks passed
@mariohamann mariohamann deleted the feat/sd-prose branch May 29, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

feat[dev]: ✨ implement sd-prose component
5 participants