-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add sd-prose (CSS Style) #930
Conversation
@yoezlem This is currently missing out migration guides. Would you be fine in moving this to a follow-up task, so that maybe someone else can take it over? @coraliefeil I would like to talk with you about |
styleName: 'sd-prose', | ||
summary: 'Prose', | ||
status: 'stable', | ||
since: '1.13', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Has to be fixed before merging.
Alright, but please create a new ticket for the migration guide :) |
Done! |
Pls reassign for another review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@coraliefeil Here the final test: https://www.chromatic.com/build?appId=64469bd84c5ea1ce2dd5d016&number=2039 |
Approved. Thank you so much. <3 |
Description:
This PR adds the
sd-prose
CSS style. In addition it fixes and refactorssd-list
, which had problems with mixed list types.Definition of Reviewable:
PR notes: Irrelevant elements should be removed.