feat: ✨ add sd-dialog #668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
29 tasks
Vahid1919
assigned azraefendic, mariohamann, coraliefeil, karlbaumhauer, yoezlem, van-nguyen-ht and EllaELSA
yoezlem
reviewed
Jan 4, 2024
|
If I close the sd-dialog and want to open it again, it seems not working? 🤔 |
|
Somehow the slots also not working? |
|
@Vahid1919 seems like all controls aren't working. Its not only for slots and the boolean for open and close the dialog. Please have a look on that! 👀 |
azraefendic
reviewed
Jan 5, 2024
|
@coraliefeil I made a small change for the scrolling story that needs approval :) |
mariohamann
reviewed
Jan 25, 2024
| SolidElement.styles, | ||
| css` | ||
| :host { | ||
| --width: 662px; |
There was a problem hiding this comment.
Is this coming from design?
There was a problem hiding this comment.
Yes. I took the exact values from there.
There was a problem hiding this comment.
Pulled the values from here:
Comment on lines
+334
to
+336
| :host { | ||
| --width: 335px; | ||
| } |
There was a problem hiding this comment.
Same: Coming from design?
mariohamann
approved these changes
Jan 25, 2024
|
Approved. |
azraefendic
approved these changes
Jan 25, 2024
yoezlem
approved these changes
Jan 29, 2024
|
Approved. THX |
karlbaumhauer
pushed a commit
that referenced
this pull request
Jan 30, 2024
# [@solid-design-system/components-v2.1.0](components/2.0.0...components/2.1.0) (2024-01-30) ### Features * ✨ add sd-dialog ([#668](#668)) ([753b6d8](753b6d8))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Added sd-dialog component. Closes #229.
Definition of Reviewable: