fix: accept full height of container #1036
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mariohamann
requested changes
May 3, 2024
| @@ -333,7 +333,7 @@ export default class SdTextarea extends SolidElement implements SolidFormControl | |||
| }[this.size]; | |||
|
|
|||
| return html` | |||
| <div part="form-control" class="text-left"> | |||
| <div part="form-control" class="flex flex-col w-full text-left"> | |||
There was a problem hiding this comment.
Does this fully preserve the ability to set rows? When does it use rows, when the height? Some documentation or even better a story would be very helpful here.
There was a problem hiding this comment.
@yoezlem Anything you need here? :)
|
I removed myself – feel free to re-add if needed. |
Vahid1919
approved these changes
May 15, 2024
azraefendic
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Changed the logic regarding #719 to accept full height inside a container
Definition of Reviewable: