Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 🤔 Input based controls do not work in sd-dialog stories #702

Closed
9 tasks
Vahid1919 opened this issue Jan 23, 2024 · 2 comments
Closed
9 tasks

fix: 🤔 Input based controls do not work in sd-dialog stories #702

Vahid1919 opened this issue Jan 23, 2024 · 2 comments
Labels
🔧 code needs changes in code

Comments

@Vahid1919
Copy link
Contributor

Vahid1919 commented Jan 23, 2024

Current behavior

While implementing sd-dialog ( #668 ), we realised that input based Controls are not working in the Docs page of the sd-dialog story.

Image

Expected behavior

Attribute controls like 'headline' or slots should let you insert text in the controls and show that change in the canvas. They should work the same way they do on the individual stories for sd-dialog.

Steps to reproduce

Open the sd-dialog component Docs page and try to use the input-based Controls. (eg: headline attribute, slots, css properties)

Technical Information

DoR

  • Item has business value
  • Item has been estimated by the team
  • Item is clear and well-defined
  • Item dependencies have been identified

DoD

  • Documentation has been created/updated (if applicable)
  • Migration Guide has been created/updated (if applicable)
  • Relevant E2E tests (Features, A11y, Bug fixes) are created/updated
  • Relevant stories (Features, A11y) are created/updated
  • Implementation works successfully on feature branch
@Vahid1919 Vahid1919 self-assigned this Jan 23, 2024
@Vahid1919 Vahid1919 changed the title fix: 🤔 Storybook Controls don't work when using iframes (inline=false) fix: 🤔 Input based controls do not work in sd-dialog stories Jan 25, 2024
@Vahid1919 Vahid1919 removed their assignment Jan 25, 2024
@Vahid1919 Vahid1919 added the 🔧 code needs changes in code label Jan 25, 2024
@yoezlem
Copy link
Contributor

yoezlem commented Mar 15, 2024

Please solve only the Bug which occurs in the sd-dialog attribute section for the headline string.

I will create another Ticket for the slot bug.

@yoezlem
Copy link
Contributor

yoezlem commented May 6, 2024

Will close this one as this is not only a sd-dialog bug. We have this problem on very story with input fields.. so this might be a duplicate of:
#1029
#898

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔧 code needs changes in code
Projects
Status: ✅ Done
Development

No branches or pull requests

2 participants