Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: 📚 Storybook Controls Don't Update UI #1029

Closed
8 tasks
Vahid1919 opened this issue May 3, 2024 · 2 comments
Closed
8 tasks

docs: 📚 Storybook Controls Don't Update UI #1029

Vahid1919 opened this issue May 3, 2024 · 2 comments

Comments

@Vahid1919
Copy link
Contributor

Description

Some controls do not reset UI changed when they are toggles. As of now, this problem only exists for the no-close-button control of sd-dialog (https://solid-design-system.fe.union-investment.de/x.x.x/storybook/?path=/docs/components-sd-dialog--docs)

Additionally the no-tail control of the sd-step also has this issue: #1007

Where to put the documentation

sd-step and sd-dialog docs page

DoR

  • Item has business value
  • Item has been estimated by the team
  • Item is clear and well-defined
  • Item dependencies have been identified

DoD

  • Documentation has been created/updated (if applicable)
  • Migration Guide has been created/updated (if applicable)
  • Relevant stories (Features, A11y) are created/updated
  • Implementation works successfully on feature branch
@Vahid1919 Vahid1919 assigned Vahid1919 and unassigned Vahid1919 May 3, 2024
@yoezlem
Copy link
Contributor

yoezlem commented May 6, 2024

Edit: All input controls have this bug.

@yoezlem
Copy link
Contributor

yoezlem commented May 6, 2024

Will close this one as this is not only a sd-dialog/sd-steps bug. We have this problem on very story with input fields.. so this might be a duplicate of:
#702
#898

@yoezlem yoezlem closed this as completed May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

No branches or pull requests

2 participants