refactor: use associated v8::Context for event setup (electron#37355)

refactor: use associated v8::Context for event setup
solarwindscloud · Feb 22, 2023 · 6395898 · 6395898
1 parent 32c60b2
commit 6395898
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 7 deletions.
diff --git a/shell/browser/electron_browser_main_parts.cc b/shell/browser/electron_browser_main_parts.cc
@@ -270,7 +270,7 @@ void ElectronBrowserMainParts::PostEarlyInitialization() {
 
   v8::HandleScope scope(js_env_->isolate());
 
-  node_bindings_->Initialize();
+  node_bindings_->Initialize(js_env_->isolate()->GetCurrentContext());
   // Create the global environment.
   node::Environment* env = node_bindings_->CreateEnvironment(
       js_env_->isolate()->GetCurrentContext(), js_env_->platform());

diff --git a/shell/common/node_bindings.cc b/shell/common/node_bindings.cc
@@ -415,7 +415,7 @@ void NodeBindings::SetNodeCliFlags() {
   }
 }
 
-void NodeBindings::Initialize() {
+void NodeBindings::Initialize(v8::Local<v8::Context> context) {
   TRACE_EVENT0("electron", "NodeBindings::Initialize");
   // Open node's error reporting system for browser process.
 
@@ -463,8 +463,7 @@ void NodeBindings::Initialize() {
     SetErrorMode(GetErrorMode() & ~SEM_NOGPFAULTERRORBOX);
 #endif
 
-  v8::Isolate* isolate = v8::Isolate::GetCurrent();
-  gin_helper::internal::Event::GetConstructor(isolate->GetCurrentContext());
+  gin_helper::internal::Event::GetConstructor(context);
 
   g_is_initialized = true;
 }

diff --git a/shell/common/node_bindings.h b/shell/common/node_bindings.h
@@ -85,7 +85,7 @@ class NodeBindings {
   virtual ~NodeBindings();
 
   // Setup V8, libuv.
-  void Initialize();
+  void Initialize(v8::Local<v8::Context> context);
 
   void SetNodeCliFlags();
 

diff --git a/shell/renderer/electron_renderer_client.cc b/shell/renderer/electron_renderer_client.cc
@@ -76,7 +76,7 @@ void ElectronRendererClient::DidCreateScriptContext(
 
   if (!node_integration_initialized_) {
     node_integration_initialized_ = true;
-    node_bindings_->Initialize();
+    node_bindings_->Initialize(renderer_context);
     node_bindings_->PrepareEmbedThread();
   }
 

diff --git a/shell/services/node/node_service.cc b/shell/services/node/node_service.cc
@@ -47,7 +47,7 @@ void NodeService::Initialize(node::mojom::NodeServiceParamsPtr params) {
 
   v8::HandleScope scope(js_env_->isolate());
 
-  node_bindings_->Initialize();
+  node_bindings_->Initialize(js_env_->isolate()->GetCurrentContext());
 
   // Append program path for process.argv0
   auto program = base::CommandLine::ForCurrentProcess()->GetProgram();