add conflict with phpstan 0.12.26 and 0.12.27 #805
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #805 +/- ##
=========================================
Coverage 90.61% 90.61%
Complexity 3530 3530
=========================================
Files 304 304
Lines 7627 7627
=========================================
Hits 6911 6911
Misses 716 716
Continue to review full report at Codecov.
|
|
Thanks! My PR that fails because of a possible Solr bug now also fails because of a phpstan bug. ;) |
dmaicher
force-pushed
the
phpstan_conflict
branch
from
4f54aed
to
1595200
Compare
dmaicher
force-pushed
the
phpstan_conflict
branch
from
1595200
to
723b957
Compare
dmaicher
changed the title
dmaicher
commented
Jun 9, 2020
| @@ -43,5 +43,8 @@ | |||
| "psr-4": { | |||
| "Solarium\\Tests\\": "tests/" | |||
| } | |||
| }, | |||
| "conflict": { | |||
There was a problem hiding this comment.
ah actually this is not good I think. It will prevent those versions to be installed for anyone using solarium. We only need this for "dev" here...
|
For now I guess we can only pin the exact version |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHPstan switched to AST based static analysis and there seem to be some issues with that.
The fail is actually wrong:
Reported the bug: phpstan/phpstan#3415