Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: the web3.js getBlock APIs now accept rewards and transactionDetails config #29000

Merged
merged 5 commits into from Dec 2, 2022
Merged

feat: the web3.js getBlock APIs now accept rewards and transactionDetails config #29000

merged 5 commits into from Dec 2, 2022

Commits on Nov 30, 2022

  1. Add transactionDetails and rewards params to getBlock API of we… 

    …b3.js
    @steveluscher
    steveluscher committed Nov 30, 2022
    Configuration menu
    Copy the full SHA
    7c75d70 View commit details
    Browse the repository at this point in the history

  2. Add the same content to the legacy call 

    …because it's such a PITA to share config between two methods and not have Typedoc throw a fit.
    @steveluscher
    steveluscher committed Nov 30, 2022
    Configuration menu
    Copy the full SHA
    27eb3d4 View commit details
    Browse the repository at this point in the history

Commits on Dec 1, 2022

  1. Add tests to exercise block deserialization in the case that `transac… 

    …tionDetails` is `none` or `accounts`
    @steveluscher
    steveluscher committed Dec 1, 2022
    Configuration menu
    Copy the full SHA
    c83e421 View commit details
    Browse the repository at this point in the history

  2. Extract the annotated account key parser into a separate struct

    @steveluscher
    steveluscher committed Dec 1, 2022
    Configuration menu
    Copy the full SHA
    90d36e7 View commit details
    Browse the repository at this point in the history

  3. Parse the getBlock() responses differently depending on the mode

    @steveluscher
    steveluscher committed Dec 1, 2022
    Configuration menu
    Copy the full SHA
    e04dfce View commit details
    Browse the repository at this point in the history