Multi threaded rocksdb cf #16227
Multi threaded rocksdb cf #16227
Conversation
ledger/Cargo.toml
Outdated
| default-features = false | ||
| features = ["lz4"] | ||
| rev = "61f323bedab7c12a1db2dcfad943761d1eb4fc64" |
There was a problem hiding this comment.
@CriesofCarrots @carllin this api change will be required for multi-threaded cf alternations. Under the hood, DB::drop_cf() now takes &self. Could you direct me to the branch for the rocksdb stall patch or use this branch at that branch?
There was a problem hiding this comment.
This is the branch for the rocksdb stall test and fix POC: https://github.com/CriesofCarrots/solana/tree/drop-cf-and-destroy-rocks-bench
The commit that adds a drop_cf method is this one, but I imagine it will need some tweaking: CriesofCarrots@c89b335
I'll work on updating the branch to your patch later today!
Codecov Report
@@ Coverage Diff @@
## master #16227 +/- ##
=======================================
Coverage 80.1% 80.1%
=======================================
Files 413 413
Lines 110490 110495 +5
=======================================
+ Hits 88558 88565 +7
+ Misses 21932 21930 -2 |
ryoqun
force-pushed
the
multi-threaded-rocksdb-cf
branch
from
d17bb0c
to
481f2d4
Compare
| git = "https://github.com/rust-rocksdb/rust-rocksdb" | ||
| default-features = false | ||
| features = ["lz4"] | ||
| rev = "0b700fe70da8ee30483fde79f44df549f8fe11ec" | ||
| features = ["lz4", "multi-threaded-cf"] |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
stale
bot
added
the
stale
|
This stale pull request has been automatically closed. Thank you for your contributions. |
Problem
upstream: rust-rocksdb/rust-rocksdb#506
Summary of Changes
context: #14586