Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix rollup dependency conflict #366

Merged
merged 3 commits into from Jun 23, 2019
Merged

Fix rollup dependency conflict #366

merged 3 commits into from Jun 23, 2019

Conversation

jstarry
Copy link
Member

@jstarry jstarry commented Jun 22, 2019

Fixes #327

@mvines
Copy link
Member

mvines commented Jun 22, 2019

Darn!

$ test -r lib/index.iife.js
The command "test -r lib/index.iife.js" exited with 1.

(from https://github.com/solana-labs/solana-web3.js/blob/master/.travis.yml#L31)

@jstarry
Copy link
Member Author

jstarry commented Jun 23, 2019

@mvines found the issue: rollup/rollup#2961

@jstarry jstarry force-pushed the fix-rollup branch 2 times, most recently from 1051857 to 12e8255 Compare June 23, 2019 04:15
mvines
mvines reviewed Jun 23, 2019
View reviewed changes
Copy link
Member

@mvines mvines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool, thanks!

rollup.config.js Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@jstarry
Copy link
Member Author

jstarry commented Jun 23, 2019 •
edited

@mvines turns out "bug" that I found in rollup is actually a feature, who knew! I closed that PR and dug a bit deeper.

The real issue is that the rollup-plugin-commonjs module calls into rollup-plugin-node-resolve and was not updated so the two were incompatible. Now that the commonjs plugin is updated, they are compatible and all is harmonious again 😌

@jstarry
Copy link
Member Author

jstarry commented Jun 23, 2019

🎉

$ test -r lib/index.iife.js
The command "test -r lib/index.iife.js" exited with 0.

@mvines
Copy link
Member

mvines commented Jun 23, 2019

Hehe awesome, I was hoping it was something dumb like that. The CI failure here is inrelated, I think I know what’s up there

@mvines mvines merged commit 84f267d into solana-labs:master Jun 23, 2019
@mvines
Copy link
Member

mvines commented Jun 25, 2019

🎉 This PR is included in version 0.16.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

mvines pushed a commit that referenced this pull request Jun 15, 2020
@jstarry @mvines
chore: rollup dependency conflict (#366)
1b97c2e 
* bump rollup-plugin-node-resolve from 4.2.3 to 5.0.0

* Fix NPM warnings

* bump rollup-plugin-commonjs from 9.3.4 to 10.0.0
@github-actions
Copy link
Contributor

github-actions bot commented Feb 2, 2023

Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mvines mvines mvines left review comments

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Debug why rollup 1.12.4 fails to generate lib/index.iife.js in CI
2 participants
@jstarry @mvines