Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(experimental): graphql: token-2022 extensions: Reallocate Instruction #2611

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

Hrushi20
Copy link
Contributor

@Hrushi20 Hrushi20 commented May 3, 2024

This PR adds support for Token-2022's Reallocate instruction in the GraphQL schema.

Continuing work on #2406.

Copy link

changeset-bot bot commented May 3, 2024

⚠️ No Changeset found

Latest commit: 8cced30

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

changeset-bot bot commented May 3, 2024

⚠️ No Changeset found

Latest commit: e469ff3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@mergify mergify bot added the community label May 3, 2024
@mergify mergify bot requested a review from a team May 3, 2024 18:58
Copy link
Collaborator

@buffalojoec buffalojoec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is close! Thanks for the continued work.

packages/rpc-graphql/src/__tests__/__setup__.ts Outdated Show resolved Hide resolved
packages/rpc-graphql/src/__tests__/transaction-tests.ts Outdated Show resolved Hide resolved
…ure-reallocate

# Conflicts:
#	packages/rpc-graphql/src/__tests__/__setup__.ts
#	packages/rpc-graphql/src/__tests__/transaction-tests.ts
#	packages/rpc-graphql/src/resolvers/instruction.ts
#	packages/rpc-graphql/src/schema/instruction.ts
type SplTokenReallocate implements TransactionInstruction {
programId: Address
account: Account
extensionTypes: [String]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just need to update this field and this one should be good to go.

@@ -86,4 +86,32 @@ export const typeTypeDefs = /* GraphQL */ `
BASE_58
BASE_64
}

enum ExtensionType {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually I think you'll also need to define a resolver to go to and from string values here. You'll see the others under resolvers/types.ts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants