New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
token-2022: Support extensions in InitializeAccount variations #2743
Conversation
1b6d486
to
e9b8157
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! Just a few comments and questions, but for the most part this is great
@joncinque , I think this is ready for another look.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really really close, just two last little questions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes, looks good!
InitializeAccount variations should initialize extensions required by the mint.
This PR adds that support.
Base and native mint cases are covered by existing test suite. The extended-mint cases still need testing, but I wanted to PR this now because: (a) that testing will be a lot easier when InitializeMint implementations for extensions are done; and (b) I wanted to see what you think of
StateWithExtensionsMut::init_extension_from_type()
and the error-type change inStateWithExtensionsMut::unpack_uninitialized()
now. Thoughts?