jit/x86: Windows support #359
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add feature flag for new JIT support
|
I cannot run my fuzzers with this; I don't currently have access to Windows machines. |
|
@ndrewh: First of all, sorry for the very late reply, which caused this very nice contribution to diverge so much from our main branch. If you still want to contribute this, could you separate the windows form the ARM stuff and rebase it? That would be really appreciated! |
Lichtso
added a commit
that referenced
this pull request
Dec 1, 2022
…drewh (Trail of Bits). See #359
Lichtso
added a commit
that referenced
this pull request
Dec 1, 2022
…drewh (Trail of Bits). See #359
Lichtso
added a commit
that referenced
this pull request
Dec 1, 2022
…drewh (Trail of Bits). See #359
Lichtso
added a commit
that referenced
this pull request
Dec 1, 2022
* Adds the memory management on windows part of the contribution from ndrewh (Trail of Bits). See #359 * Factors out common code. * Moves memory_management into its own file.
|
The win api part of this PR is merged with #422. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This contribution is on behalf of Trail of Bits. This depends on the refactor in #358.
This adds Windows support to the x86 JIT. The only differences are we have to use the windows virtual memory API (ie. VirtualAlloc, etc.) and we have to abide by slightly different calling conventions. This was not tested on ARM64 windows.
Windows support passes tests, but is not ready for production use, and is gated behind a feature flag:
jit-windows-not-safe-for-production.This also includes a few extra comments documenting parts of the x86 JIT.
Fixes: #217