Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JIT: Windows not supported #217

Open
joncinque opened this issue Sep 22, 2021 · 1 comment · May be fixed by #359
Open

JIT: Windows not supported #217

joncinque opened this issue Sep 22, 2021 · 1 comment · May be fixed by #359

Comments

@joncinque
Copy link

joncinque commented Sep 22, 2021 •
edited

The JIT only supports non-Windows targets:

rbpf/src/jit.rs

Lines 934 to 937 in c3dd337

#[cfg(target_os = "windows")]
{
panic!("JIT not supported on windows");
}

This issue is not pressing, nor is it a call to action. Instead, it can be used for tracking in other systems that may be blocked. I imagine a Windows-JIT will be difficult to implement because of all the POSIX-specific parts of the implementation, and yield very little reward.
@Lichtso
Copy link

Lichtso commented Sep 27, 2021

It is not so much POSIX, as the only thing POSIX we are using is mmap / mprotect and there should be replacements for that on windows: https://docs.microsoft.com/en-us/windows/win32/api/memoryapi/

The way bigger problem is that windows does not use the System V ABI like everybody else does. So all the x86 registers and the call stack work differently.

@fanatid fanatid mentioned this issue Nov 9, 2021
Merged
@Lichtso Lichtso linked a pull request Aug 24, 2022 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

jit/x86: Windows support trail-of-forks/rbpf
2 participants
@Lichtso @joncinque