Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: setting prettier and update eslint default config #322

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

pmpwith2i
Copy link

@pmpwith2i pmpwith2i commented Mar 7, 2023

Description

This PR introduces some changes to default configuration of eslint and also update packages configuration in order to use prettier and the formatter for tailwindCSS classes.
This PR will introduce a refactor of many files in order to fit the new style rules, nothing changed in the core of the application.

Issue

This PR closes #291

@pmpwith2i
Copy link
Author

pmpwith2i commented Mar 7, 2023

Hi @DonnySolana, while using this scaffold I added some configurations and I think that could be useful for other users to use it. Feel free to remove/add rules on eslint or to deny this PR.
After this changes some files will be broken so a refactor should be done, I could do it
Thanks! ♥︎

@DonnySolana
Copy link
Contributor

hey thanks! what will the refactor look like? If you do not mind doing it, it may make more sense to do it at once and make sure everything runs smooth.

@pmpwith2i
Copy link
Author

pmpwith2i commented Mar 7, 2023

hey thanks! what will the refactor look like? If you do not mind doing it, it may make more sense to do it at once and make sure everything runs smooth.

Hey, essentially most of the refactor would be only to fix code style like quotes and indent. Then there are some typing issues to solve, I’ll do it in these days:)

@pmpwith2i
Copy link
Author

@DonnySolana I updated the code, almost of the 38 files changed are automatically updated by prettier and eslint, I just removed some memo not needed where the file are imported from an external module (because it never changes), like the notify

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add prettier code formatter
2 participants