Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BraavosSigner #1199

Closed
wants to merge 4 commits into from
Closed

Add BraavosSigner #1199

wants to merge 4 commits into from

Conversation

tomek0123456789
Copy link
Collaborator

Closes #1056

Introduced changes

  • added BraavosSigner

  • This PR contains breaking changes

@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

Attention: 49 lines in your changes are missing coverage. Please review.

Comparison is base (40a1ee3) 97.51% compared to head (ccfa1de) 96.58%.
Report is 1 commits behind head on development.

Additional details and impacted files
@@               Coverage Diff               @@
##           development    #1199      +/-   ##
===============================================
- Coverage        97.51%   96.58%   -0.93%     
===============================================
  Files               92       93       +1     
  Lines             4674     4721      +47     
===============================================
+ Hits              4558     4560       +2     
- Misses             116      161      +45     
Files Coverage Δ
starknet_py/net/account/account.py 98.99% <ø> (ø)
starknet_py/net/signer/braavos_signer.py 0.00% <0.00%> (ø)

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ddoktorski ddoktorski closed this May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider implementing Braavos signer
2 participants