Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[scarb-doc] Scarb packages #1289

Merged
merged 5 commits into from May 14, 2024
Merged

[scarb-doc] Scarb packages #1289

merged 5 commits into from May 14, 2024

Conversation

drknzz
Copy link
Member

@drknzz drknzz commented Apr 30, 2024

No description provided.

@drknzz drknzz requested a review from Arcticae April 30, 2024 13:22
@drknzz drknzz marked this pull request as ready for review April 30, 2024 13:22
@drknzz drknzz requested a review from maciektr as a code owner April 30, 2024 13:22
Base automatically changed from cairodoc-crate to main April 30, 2024 13:59
@maciektr
Copy link
Contributor

Pls rebase

maciektr
maciektr requested changes May 6, 2024
View reviewed changes
extensions/scarb-doc/src/main.rs Outdated Show resolved Hide resolved
extensions/scarb-doc/src/main.rs Show resolved Hide resolved
extensions/scarb-doc/src/main.rs Outdated Show resolved Hide resolved
extensions/scarb-doc/src/main.rs Outdated Show resolved Hide resolved
extensions/scarb-doc/src/main.rs Outdated Show resolved Hide resolved
maciektr
maciektr approved these changes May 7, 2024
View reviewed changes
Copy link
Contributor

@maciektr maciektr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Arcticae
Arcticae reviewed May 7, 2024
View reviewed changes
Copy link
Member

@Arcticae Arcticae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can it select different crates from a workspace?
I think this case should be tested

@drknzz @maciektr
Update extensions/scarb-doc/tests/test.rs
1e6ca48 
Co-authored-by: maciektr <maciej.tratnowiecki@swmansion.com>
Signed-off-by: Kamil Jankowski <kamil.jankowski.x@gmail.com>
@drknzz drknzz added this pull request to the merge queue May 14, 2024
Merged via the queue into main with commit e813dba May 14, 2024
22 checks passed
@drknzz drknzz deleted the scarb-doc/scarb-package branch May 14, 2024 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Arcticae Arcticae Arcticae left review comments

@maciektr maciektr maciektr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@drknzz @maciektr @Arcticae