Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: expose missing props in ScreenProps #1588

Merged
merged 2 commits into from Sep 14, 2022

Conversation

kacperkapusciak
Copy link
Member

@kacperkapusciak kacperkapusciak commented Sep 13, 2022

Description

This PR exposes the preventNativeDismiss and onNativeDismissCancelled props for library authors used for preventing native navigation. We should not expose these props in the native-stack.

Code in react-navigation which uses these props can be seen here:
https://github.com/react-navigation/react-navigation/blob/main/packages/native-stack/src/views/NativeStackView.native.tsx#L270

Changes

  • Added preventNativeDismiss and onNativeDismissCancelled props to ScreenProps in src/types.tsx
  • Added preventNativeDismiss and onNativeDismissCancelled props to GUIDE_FOR_LIBRARY_AUTHORS.md
  • Reformated GUIDE_FOR_LIBRARY_AUTHORS.md file
  • Sorted freezeOnBlur prop alphabetically in src/types.tsx and src/native-stack/types.tsx

Checklist

@kacperkapusciak kacperkapusciak changed the title fix: expose preventNativeDismiss prop in ScreenProps fix: expose missing props in ScreenProps Sep 14, 2022
Copy link
Member

@kkafar kkafar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, works fine with VSCode 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants