Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: build only arm64-v8a architecture on CI for Fabric Android build #1578

Merged
merged 4 commits into from Aug 31, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/android-build-test-fabric.yml
Expand Up @@ -9,6 +9,7 @@ on:
- 'src/fabric/**'
- 'FabricTestExample/**'
- 'package.json'
- '.github/workflows/android-build-test-fabric.yml'
push:
branches:
- main
Expand All @@ -35,4 +36,4 @@ jobs:
run: yarn
- name: Build app
working-directory: ${{ env.WORKING_DIRECTORY }}/android
run: ./gradlew assembleDebug --console=plain
run: ./gradlew assembleDebug --console=plain -PreactNativeArchitectures=arm64-v8a
3 changes: 3 additions & 0 deletions .github/workflows/android-build-test.yml
Expand Up @@ -5,6 +5,9 @@ on:
- main
paths:
- 'android/**'
- 'package.json'
- 'TestsExample/**'
- '.github/workflows/android-build-test.yml'
push:
branches:
- main
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/android-e2e-test.yml
Expand Up @@ -7,6 +7,7 @@ on:
- 'android/**'
- 'common/**'
- 'Example/**'
- 'TestsExample/**'
push:
branches:
- main
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/ios-e2e-test.yml
Expand Up @@ -8,6 +8,7 @@ on:
- 'ios/**'
- 'common/**'
- 'Example/**'
- 'TestsExample/**'
push:
branches:
- main
Expand Down
5 changes: 5 additions & 0 deletions FabricExample/android/app/build.gradle
Expand Up @@ -154,6 +154,11 @@ android {
"-DANDROID_STL=c++_shared"
}
}
if (!enableSeparateBuildPerCPUArchitecture) {
ndk {
abiFilters (*reactNativeArchitectures())
}
}
}
}

Expand Down
5 changes: 5 additions & 0 deletions FabricTestExample/android/app/build.gradle
Expand Up @@ -152,6 +152,11 @@ android {
"-DANDROID_STL=c++_shared"
}
}
if (!enableSeparateBuildPerCPUArchitecture) {
ndk {
abiFilters (*reactNativeArchitectures())
}
}
}
}

Expand Down