fix: use angle-bracket imports #1572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j-piasecki
pushed a commit
to software-mansion/react-native-gesture-handler
that referenced
this pull request
Aug 24, 2022
## Description This PR replaces bad double-quotes imports (which break Swift interop) with good angle-bracket imports. The forbidden pattern is: `#import "RCT` See also: * software-mansion/react-native-reanimated#3150 * software-mansion/react-native-screens#1572 * software-mansion/react-native-svg#1848 <!-- Description and motivation for this PR. Inlude 'Fixes #<number>' if this is fixing some issue. --> ## Test plan <!-- Describe how did you test this change here. --> Check if Example and FabricExample apps compile successfully.
This was referenced Oct 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR replaces bad double-quotes imports (which break Swift interop) with good angle-bracket imports.
The forbidden pattern is:
#import "RCTSee also:
Changes
Test code and steps to reproduce
Checklist