New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Monorepo [0/?] - move move github actions to root #5993
Open
tjzel
wants to merge
38
commits into
@tjzel/monorepo
Choose a base branch
from
@tjzel/monorepo-github-actions
base: @tjzel/monorepo
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjzel
commented
May 9, 2024
java-version: 17 | ||
|
||
- name: Restore Reanimated node_modules from cache | ||
uses: actions/cache@v3 | ||
with: | ||
path: node_modules | ||
key: ${{ runner.os }}-android-node-modules-reanimated-${{ hashFiles('yarn.lock') }} | ||
path: packages/react-native-reanimated/node_modules |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @tomekzaw
If you could explain to me (preferably offline) how does the memoization work here.
This was referenced May 10, 2024
Open
tjzel
changed the title
Monorepo - move move github actions to root
Monorepo [0/?] - move move github actions to root
May 15, 2024
This was referenced May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About
This pull request is a part of the effort of migrating to monorepo structure:
Summary
Moving
.github
directory to the root of the project, alongside with fixes that regard new repository structures.This pull request won't fix CIs which are being tackled in
Test plan
No CI should fail on a step related to the change of the monorepo structure.
Steps achieved towards monorepo