Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monorepo [0/?] - move move github actions to root #5993

Open
wants to merge 38 commits into
base: @tjzel/monorepo
Choose a base branch
from

Conversation

tjzel
Copy link
Contributor

@tjzel tjzel commented May 8, 2024

About

This pull request is a part of the effort of migrating to monorepo structure:

Summary

Moving .github directory to the root of the project, alongside with fixes that regard new repository structures.

This pull request won't fix CIs which are being tackled in

Test plan

No CI should fail on a step related to the change of the monorepo structure.

Steps achieved towards monorepo

  • All CI pass
  • Precommit scripts work properly
  • react-native-reanimated is a separate workspace which uses hoisted node_modules
  • app is a separate workspace which uses hoisted node_modules
  • paper example is a separate workspace which uses hoisted node_modules
  • fabric example is a separate workspace which uses hoisted node_modules
  • web example is a separate workspace which uses hoisted node_modules
  • macos example is a separate workspace which uses hoisted node_modules
  • example is a separate workspace which uses hoisted node_modules
  • reanimated eslint plugin is a separate workspace which uses hoisted node_modules
  • the npm package builds and works as expected
  • reanimated2 directory is removed
  • TypeScript, ESLint and Prettier configs are unified and only extended when necessary in workspaces

@tjzel tjzel marked this pull request as draft May 8, 2024 14:21
java-version: 17

- name: Restore Reanimated node_modules from cache
uses: actions/cache@v3
with:
path: node_modules
key: ${{ runner.os }}-android-node-modules-reanimated-${{ hashFiles('yarn.lock') }}
path: packages/react-native-reanimated/node_modules
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @tomekzaw

If you could explain to me (preferably offline) how does the memoization work here.

@tjzel tjzel marked this pull request as ready for review May 9, 2024 16:45
@tjzel tjzel requested a review from piaskowyk May 9, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant