Fix EXC_BAD_ACCESS crash on iOS in [REAAnimationsManager clearSharedTransitionConfigForTag:]
#5975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #5947. Fixes #5968.
When
react-native-reanimatedis installed but not used directly, switching between bottom tabs from@react-navigation/bottom-tabswill result in aEXC_BAD_ACCESScrash on iOS.This PR adds missing mock for
_clearSharedTransitionConfigForTagas suggested by @bartlomiejbloniarz.Test plan
Try repro from #5947 (comment)