Make Reanimated more compliant with rules of React #5942
Conversation
|
|
||
| export default function RuntimeTestsRunner() { | ||
| const isRenderLocked = useRef<boolean>(false); |
There was a problem hiding this comment.
cc @Latropos
How to properly define this lock inside this component?
There was a problem hiding this comment.
Isn't it outdated already?
| const outRef = ref ?? animatedRef; | ||
|
|
||
| // @ts-expect-error TODO: Allow null as `useScrollViewOffset` ref argument. | ||
| useScrollViewOffset(null, scrollViewOffset); |
There was a problem hiding this comment.
cc @szydlovsky
Pls make it work in useScrollViewOffset (we are prisoners of our own API 💀)
There was a problem hiding this comment.
@tjzel do we really need nullable ref here that badly? Changing it will really complicate the hook implementation. The current native implementation also throws a warning when there is no ref - which I remember may have been your idea. After all, this hook with a null ref does essentially nothing so what do we need it for?
There was a problem hiding this comment.
Definitely we don't need to use nullable ref here. However:
- We shouldn't call this hook conditionally like before.
- The user can pass to
Animated.ScrollVieweither:
2.1 An AnimatedRef - then we have no problems whatsoever.
2.2 A plain ref from React - then it will cause a runtime error.
In scenario 2.2 we would need to check if the passed ref is not an Animated one. If it's not, my idea would be to pass null to useScrollViewOffset hook as a special case that it shouldn't do anything. Keep in mind that we cannot just pass animatedRef to it as for now, since in this scenario it's never getting attached to anything and causes another error.
I haven't came up with some other solution here that wouldn't be hacky. If you have a better solution though, I'm all ears.
| @@ -41,13 +41,16 @@ export function useFrameCallback( | |||
| }); | |||
|
|
|||
| useEffect(() => { | |||
| // Unregister previous callback. | |||
| frameCallbackRegistry.unregisterFrameCallback(ref.current.callbackId); | |||
There was a problem hiding this comment.
Was unregistering here overlooked or is it not necessary? cc @tomekzaw @piaskowyk
Summary
Test plan