New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing docs details #5922
Open
xnameTM
wants to merge
39
commits into
main
Choose a base branch
from
@xnameTM/fixing-details
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Fixing docs details #5922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…M/react-native-reanimated into @xnameTM/convert-ts-to-js
## Summary This pr adds TypeScript templates of code in the Reanimated Docs. ## How is it work? I rewrote the `.jsx` exercises to `.tsx` and I added tsx to jsx code compilation in the InteractiveExample component. ## How to test this feature? Command to change current working dictionary: > cd docs Command to download libraries: > yarn install Command to preview the project: > yarn start # Screenshots ![Zrzut ekranu 2024-04-8 o 11 33 57](https://github.com/software-mansion/react-native-reanimated/assets/80314375/219ad5ed-681a-43a7-b962-e9fff0a739a5) ![Zrzut ekranu 2024-04-8 o 11 34 26](https://github.com/software-mansion/react-native-reanimated/assets/80314375/69e59174-0273-4c6f-a356-4c231180884b) ![Zrzut ekranu 2024-04-8 o 11 34 46](https://github.com/software-mansion/react-native-reanimated/assets/80314375/acc3a65a-50d6-453f-8a10-b808d173bffa)
piaskowyk
reviewed
Apr 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
docs/src/components/InteractivePlayground/useDecayPlayground/index.tsx
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pr includes changes such as fixing
thumbs
in playgrounds, fixinginteractive
Reanimated
text on mobile devices, and addedresponsiveness
to examples and playgrounds.How to test this feature?
Command to change current working dictionary:
Command to download libraries:
Command to preview changes: