Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test two ways to use sharedValue in useAnimatedStyle #5893

Merged
merged 9 commits into from May 6, 2024

Conversation

Latropos
Copy link
Contributor

@Latropos Latropos commented Apr 12, 2024

Summary

In many animations we have two ways of implementing them - we can use withTiming either inside useAnimatedStyle or outside. For simplicity I've decided to name test cases with useAnimatedStyle actively updating shared value as "ACTIVE", and if from useAnimatedStyle we observe it I call test case "PASSIVE". So these test cases are either ACTIVE or PASSIVE from the point of view of the hook useAnimatedStyle

Test plan

@Latropos Latropos changed the title Add more tests Test for two usages of useAnimatedSyle Apr 15, 2024
@Latropos Latropos requested a review from piaskowyk April 15, 2024 09:11
@Latropos Latropos marked this pull request as ready for review April 15, 2024 09:11
@Latropos Latropos changed the title Test for two usages of useAnimatedSyle Test two ways to use sharedValue in useAnimatedSyle Apr 15, 2024
@tomekzaw tomekzaw changed the title Test two ways to use sharedValue in useAnimatedSyle Test two ways to use sharedValue in useAnimatedStyle Apr 17, 2024
Copy link
Contributor

@szydlovsky szydlovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - left just a super small cosmetic comment

@Latropos Latropos added this pull request to the merge queue May 6, 2024
Merged via the queue into main with commit 8d2c491 May 6, 2024
7 checks passed
@Latropos Latropos deleted the acynk/add_more_tests branch May 6, 2024 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants