Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update useAnimatedKeyboard docs #5866

Merged
merged 11 commits into from May 9, 2024

Conversation

maciekstosio
Copy link
Contributor

@maciekstosio maciekstosio commented Apr 4, 2024

Summary

This PR updates the useAnimatedKeyboard docs to current doc pattern + add more detailed remarks discovered while doing #5851. It's pointing to #5851 and assumes changes from that PR, so should be merged after.

Test plan

cd docs
yarn
yarn start

and go to useAnimatedKeyboard section

docs/docs/device/useAnimatedKeyboard.mdx Outdated Show resolved Hide resolved
docs/docs/device/useAnimatedKeyboard.mdx Outdated Show resolved Hide resolved
docs/docs/device/useAnimatedKeyboard.mdx Outdated Show resolved Hide resolved
docs/docs/device/useAnimatedKeyboard.mdx Outdated Show resolved Hide resolved
maciekstosio and others added 4 commits April 5, 2024 10:15
Co-authored-by: Tomek Zawadzki <tomasz.zawadzki@swmansion.com>
Co-authored-by: Tomek Zawadzki <tomasz.zawadzki@swmansion.com>
Co-authored-by: Tomek Zawadzki <tomasz.zawadzki@swmansion.com>
Co-authored-by: Tomek Zawadzki <tomasz.zawadzki@swmansion.com>
Copy link
Member

@kacperkapusciak kacperkapusciak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Please address the comments before merging but other than that lgtm!

docs/docs/device/useAnimatedKeyboard.mdx Show resolved Hide resolved
docs/docs/device/useAnimatedKeyboard.mdx Outdated Show resolved Hide resolved
maciekstosio and others added 2 commits April 8, 2024 17:01
Co-authored-by: Kacper Kapuściak <39658211+kacperkapusciak@users.noreply.github.com>
Base automatically changed from @maciekstosio/Investigate-unexpected-space-when-using-useAnimatedKeyboard to main May 1, 2024 08:11
@maciekstosio maciekstosio added this pull request to the merge queue May 9, 2024
Merged via the queue into main with commit 637429d May 9, 2024
7 checks passed
@maciekstosio maciekstosio deleted the @maciekstosio/useAnimatedKeyboard-update-docs branch May 9, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants