Improve code quality of helper classes of createAnimatedComponent #5804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Latropos
reviewed
Mar 18, 2024
Comment on lines
132
to
134
| _inlinePropsViewDescriptors: ViewDescriptorsSet | null = null; | ||
| _inlinePropsMapperId: number | null = null; | ||
| _inlineProps: StyleProps = {}; |
There was a problem hiding this comment.
Suggested change
| _inlinePropsViewDescriptors: ViewDescriptorsSet | null = null; | |
| _inlinePropsMapperId: number | null = null; | |
| _inlineProps: StyleProps = {}; | |
| private _inlinePropsViewDescriptors: ViewDescriptorsSet | null = null; | |
| private _inlinePropsMapperId: number | null = null; | |
| private _inlineProps: StyleProps = {}; |
| @@ -132,14 +132,15 @@ export class InlinePropManager implements IInlinePropManager { | |||
| _inlinePropsViewDescriptors: ViewDescriptorsSet | null = null; | |||
| _inlinePropsMapperId: number | null = null; | |||
| _inlineProps: StyleProps = {}; | |||
| private _component: AnimatedComponent; | |||
There was a problem hiding this comment.
Why this is called _component and in JSPropUpdater we call it _animatedComponent? Both are animated, aren't they?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
It was getting me mad for quite some time. Here I remove passing
thisto the methods of the helper classes - instead they are passed in the constructor.Test plan
馃殌