Fix eslint config #5720
Merged
Fix eslint config #5720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Latropos
reviewed
Feb 23, 2024
|
@Latropos done! |
Latropos
approved these changes
Apr 29, 2024
|
@Latropos you were right, I actually had to downgrade it to ESlint 8 due to breaking changes 馃ぃ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Because we use ESlint rules that require a parses, proper amendments to the
.eslintrc.jshad to be made. Because of that we can also finally extend main.eslintrc.jsconfig in sub-directiories.You can read more here.
As a note, I recommend
eslint --print-config <file>to debug if the rules are actually extended etc.Test plan
馃殌