[Rea2] Restore using prebuilt binaries #3608
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piaskowyk
changed the title
kkafar
reviewed
Sep 26, 2022
Comment on lines
-177
to
-191
| def JS_RUNTIME = { | ||
| // Returns the js runtime explicitly requested in the environment variable | ||
| if (System.getenv("JS_RUNTIME")) { | ||
| return System.getenv("JS_RUNTIME") | ||
| } | ||
|
|
||
| // Detect js runtime from project setup | ||
| def defaultRuntimeType = "jsc"; | ||
| def v8Project = rootProject.getSubprojects().find { project -> project.name == "react-native-v8" } | ||
| if (v8Project != null) { | ||
| return "v8" | ||
| } | ||
| def appProject = findProject(":app") ? project(":app") : null | ||
| return appProject?.ext?.react?.enableHermes ? "hermes" : defaultRuntimeType | ||
| }.call() |
There was a problem hiding this comment.
Havent tested the behaviour, but code wise it looks fine.
One note: do we want to remove support for v8?
tomekzaw
requested changes
Sep 26, 2022
| @@ -737,7 +868,7 @@ afterEvaluate { | |||
|
|
|||
| if (CLIENT_SIDE_BUILD) { | |||
There was a problem hiding this comment.
Are CLIENT_SIDE_BUILD and BUILD_FROM_SOURCE somehow related? If yes, can we use only BUILD_FROM_SOURCE?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We used the Gradle script from the main branch (Reanimated 3) for Reanimated 2. However, Reanimated3's Gradle script doesn't use prebuilt binaries from the Reanimated package. I restored the Gradle code from the 2.9.1 version.