Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI issues with yarn #5996

Merged
merged 18 commits into from May 15, 2024
Merged

Fix CI issues with yarn #5996

merged 18 commits into from May 15, 2024

Conversation

tjzel
Copy link
Contributor

@tjzel tjzel commented May 9, 2024

Summary

Due to changes to React Native app template, it uses Yarn 3.6.4 out of the box now. This version of Yarn cannot resolve packages from GitHub's pull request refs. Therefore we have to resolve it for it and install via a downloaded package. It's not something crazy - Yarn 1 would do exactly those steps.

Test plan

  • Test V8
  • Test monorepo build
  • Check static framework
  • Test build on Windows

Should not fail on the dependency installing steps with yarn. Ideally, they shouldn't fail at all.

@tjzel tjzel marked this pull request as draft May 9, 2024 14:25
@tjzel
Copy link
Contributor Author

tjzel commented May 9, 2024

I fixed issues with regard to RN template using Yarn 3.6.4 by default.

@tomekzaw @piaskowyk Could you take a look at the failing V8 and monorepo CIs? I have the following questions.

  1. Does V8 CI fail because it doesn't yet support RN 0.74? Maybe you can see it on the spot, I haven't investigated it.

  2. What's exactly the purpose of the monorepo CI? It creates the following file structure:

.
└── monorepo
    ├── RootApp
    └── packages
        └── PackageApp

Which doesn't make a lot of sense - creating the RootApp step. Could you explain a bit your intentions behind this?

EDIT: Thanks for discussing it with me offline.

@tjzel tjzel marked this pull request as ready for review May 15, 2024 11:09
@tjzel tjzel added this pull request to the merge queue May 15, 2024
Merged via the queue into main with commit 6e08def May 15, 2024
13 checks passed
@tjzel tjzel deleted the @tjzel/CI-issues-with-yarn branch May 15, 2024 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants