Update plugin error message #3437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomekzaw
reviewed
Aug 12, 2022
Co-authored-by: Tomek Zawadzki <tomasz.zawadzki@swmansion.com>
Co-authored-by: Tomek Zawadzki <tomasz.zawadzki@swmansion.com>
Merged
tomekzaw
approved these changes
Aug 16, 2022
Co-authored-by: Tomek Zawadzki <tomasz.zawadzki@swmansion.com>
Co-authored-by: Tomek Zawadzki <tomasz.zawadzki@swmansion.com>
Co-authored-by: Tomek Zawadzki <tomasz.zawadzki@swmansion.com>
Co-authored-by: Tomek Zawadzki <tomasz.zawadzki@swmansion.com>
Co-authored-by: Tomek Zawadzki <tomasz.zawadzki@swmansion.com>
piaskowyk
added a commit
that referenced
this pull request
Aug 17, 2022
## Description Tree-shaking requires `export * as default` syntax, but this syntax requires the babel plugin `@babel/plugin-proposal-export-namespace-from`. Previously I embedded this plugin inside the Reanimated plugin, but this doesn't work when someone doesn't add Reanimated plugin to their project. In this situation, users receive misleading information about syntax errors instead of messages about missing plugin configuration. Tree-shaking works only for the web, so I used `as default` syntax only for web implementation. In addition, I updated the exception message. The file `index.web.ts` contains information about exceptions in the comment because this is the only possibility to give users information on exceptions during static analyzes of code. Fixes #3410
3 tasks
j-piasecki
added a commit
to software-mansion/react-native-gesture-handler
that referenced
this pull request
Oct 21, 2022
## Description This PR fixes the order of babel plugins and adds `@babel/plugin-proposal-export-namespace-from` to make the new versions of Reanimated work on web. See software-mansion/react-native-reanimated#3437 for more information. ## Test plan Run example apps
byCedric
added a commit
to expo/snack
that referenced
this pull request
Nov 2, 2022
byCedric
added a commit
to expo/snack
that referenced
this pull request
Nov 10, 2022
* fix(runtime): drop sdkVersion from app.json * refactor(runtime): upgrade to Expo SDK 47 beta * refactor(runtime): update patches to used package versions * refactor(snack-content): upgrade to Expo SDK 47 beta * refactor(snack-sdk): upgrade bundled native modules fixture to Expo SDK 47 beta * test(snack-sdk): update the tests for Expo SDK 47 beta * docs(snack-sdk): add changelog entries * refactor(website): upgrade to Expo SDK 47 beta * fix(runtime): use event subscriptions in app * fix(runtime: change barcode scanned types to match code * test(snackager): update to Expo SDK 47 beta * docs: update changelogs to include pr * fix(runtime): work around reanimated issue #3437 See: software-mansion/react-native-reanimated#3437 See: expo/expo#19305 * fix(runtime): fix deployment script removing sdkVersion usage * refactor(runtime): update dependencies for SDK 47 stable * refactor(snack-sdk): upgrade bundled native modules fixture to Expo SDK 47 stable * test(snack-sdk): update the tests for Expo SDK 47 stale
fluiddot
pushed a commit
to wordpress-mobile/react-native-reanimated
that referenced
this pull request
Jun 5, 2023
## Description Tree-shaking requires `export * as default` syntax, but this syntax requires the babel plugin `@babel/plugin-proposal-export-namespace-from`. Previously I embedded this plugin inside the Reanimated plugin, but this doesn't work when someone doesn't add Reanimated plugin to their project. In this situation, users receive misleading information about syntax errors instead of messages about missing plugin configuration. Tree-shaking works only for the web, so I used `as default` syntax only for web implementation. In addition, I updated the exception message. The file `index.web.ts` contains information about exceptions in the comment because this is the only possibility to give users information on exceptions during static analyzes of code. Fixes software-mansion#3410
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Tree-shaking requires
export * as defaultsyntax, but this syntax requires the babel plugin@babel/plugin-proposal-export-namespace-from. Previously I embedded this plugin inside the Reanimated plugin, but this doesn't work when someone doesn't add Reanimated plugin to their project. In this situation, users receive misleading information about syntax errors instead of messages about missing plugin configuration.Tree-shaking works only for the web, so I used
as defaultsyntax only for web implementation. In addition, I updated the exception message.The file
index.web.tscontains information about exceptions in the comment because this is the only possibility to give users information on exceptions during static analyzes of code.Fixes #3410