Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[apps] NCL: fix web build with Reanimated #19305

Merged
merged 3 commits into from Sep 30, 2022
Merged

[apps] NCL: fix web build with Reanimated #19305

merged 3 commits into from Sep 30, 2022

Conversation

Simek
Copy link
Collaborator

@Simek Simek commented Sep 29, 2022

Why

Fixes https://github.com/expo/expo/actions/runs/3153362442/jobs/5129746889

How

This PR adds a Babel plugin which allow to parse exports from the latest release of Reanimated while running web app.

Test Plan

yarn web launches NCL instead of crashing.

Checklist

@expo-bot expo-bot added the bot: passed checks ExpoBot has nothing to complain about label Sep 29, 2022
@Simek Simek requested review from tsapeta and Kudo September 29, 2022 18:30
@Simek Simek marked this pull request as draft September 29, 2022 18:31
@Simek
Copy link
Collaborator Author

Simek commented Sep 29, 2022

NCL web app build correctly now, but Reanimated and Skia pages are crashing, so it's not a complete fix, rather a step in the process.

@Simek Simek marked this pull request as ready for review September 29, 2022 18:36
@Kudo
Copy link
Contributor

Kudo commented Sep 30, 2022

thanks for taking care of this. the yarn.lock is not quite correct (the util package is not pinned by resolutions). please try to do yarn install from workspace root again.

fwiw, the babel plugin is officially now required: software-mansion/react-native-reanimated#3437

i think skia broken on web may be expected. we didn't setup canvaskit correctly when i added the example 😅
i'm investigating why reanimated example still throwing errors as you mentioned.

@Kudo
Copy link
Contributor

Kudo commented Sep 30, 2022 •
edited

i'm investigating why reanimated example still throwing errors as you mentioned.

oh we may require the fix: software-mansion/react-native-reanimated#3624.
@tsapeta could you help to check with reanimated team whether they could publish a new v2 release for us preparing sdk 47?

@tomekzaw
Copy link
Contributor

could you help to check with reanimated team whether they could publish a new v2 release for us preparing sdk 47?

@Kudo We plan to release Reanimated 2.11.0 early next week, is this okay?

@Kudo
Copy link
Contributor

Kudo commented Sep 30, 2022

@Kudo We plan to release Reanimated 2.11.0 early next week, is this okay?

that's great! thanks @tomekzaw

Kudo
Kudo approved these changes Sep 30, 2022
View reviewed changes
Copy link
Contributor

@Kudo Kudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 thanks for this fix

@Simek Simek merged commit ca94fe5 into main Sep 30, 2022
@Simek Simek deleted the @simek/apps-fix-ncl-web branch September 30, 2022 10:35
byCedric added a commit to expo/snack that referenced this pull request Nov 2, 2022
@byCedric
fix(runtime): work around reanimated issue #3437
a89ff75 
See: software-mansion/react-native-reanimated#3437
See: expo/expo#19305
byCedric added a commit to expo/snack that referenced this pull request Nov 10, 2022
@byCedric
Upgrade to Expo SDK 47 (#360)
c7775ed 
* fix(runtime): drop sdkVersion from app.json

* refactor(runtime): upgrade to Expo SDK 47 beta

* refactor(runtime): update patches to used package versions

* refactor(snack-content): upgrade to Expo SDK 47 beta

* refactor(snack-sdk): upgrade bundled native modules fixture to Expo SDK 47 beta

* test(snack-sdk): update the tests for Expo SDK 47 beta

* docs(snack-sdk): add changelog entries

* refactor(website): upgrade to Expo SDK 47 beta

* fix(runtime): use event subscriptions in app

* fix(runtime: change barcode scanned types to match code

* test(snackager): update to Expo SDK 47 beta

* docs: update changelogs to include pr

* fix(runtime): work around reanimated issue #3437

See: software-mansion/react-native-reanimated#3437
See: expo/expo#19305

* fix(runtime): fix deployment script removing sdkVersion usage

* refactor(runtime): update dependencies for SDK 47 stable

* refactor(snack-sdk): upgrade bundled native modules fixture to Expo SDK 47 stable

* test(snack-sdk): update the tests for Expo SDK 47 stale
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kudo Kudo Kudo approved these changes

@tsapeta tsapeta Awaiting requested review from tsapeta

Assignees
No one assigned
Labels
bot: passed checks ExpoBot has nothing to complain about
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Simek @Kudo @tomekzaw @expo-bot