Add compatibility with Next
#2852
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j-piasecki
requested changes
Apr 8, 2024
piaskowyk
reviewed
Apr 8, 2024
| @@ -0,0 +1,12 @@ | |||
| import { findDOMNode } from 'react-dom'; | |||
There was a problem hiding this comment.
Maybe let's add a comment why this file even exists
| @@ -52,7 +52,7 @@ export default class PanGestureHandler extends GestureHandler { | |||
| private lastY = 0; | |||
|
|
|||
| private activateAfterLongPress = 0; | |||
| private activationTimeout = 0; | |||
| private activationTimeout: ReturnType<typeof setTimeout> | undefined; | |||
There was a problem hiding this comment.
Is this change in a scope of this PR?
There was a problem hiding this comment.
At the beginning it was, because I added node types into tsconfig. Later on I've removed them, as @j-piasecki suggested (now we have @ts-ignore, if you see better option - I'd be glad to hear it).
I brought back old types in a2185c6.
j-piasecki
approved these changes
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to bring compatibility with
Next.jsappsTest plan
Run Next.js app with Gesture Handler installed from package created from this PR.