Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix updating draft releases #255

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix updating draft releases #255

wants to merge 3 commits into from

Commits on Feb 9, 2023

  1. Change existingRelease to be a Release rather than a Promise 

    No real changes yet, this is just a small cleanup before the upcoming
commits.
    @vadz
    vadz committed Feb 9, 2023
    Configuration menu
    Copy the full SHA
    bdee2a8 View commit details
    Browse the repository at this point in the history

  2. Search for existing draft releases by name, not by tag 

    The tag is typically (or maybe even always) empty for the draft
releases and can't be really used, while the release name will normally
be unique, so use it as the key.
    @vadz
    vadz committed Feb 9, 2023
    Configuration menu
    Copy the full SHA
    9414f12 View commit details
    Browse the repository at this point in the history

  3. Fix updating an existing draft release 

    Don't just return the release without doing anything else, notably this
didn't allow updating an existing draft release body.

This change required refactoring the code to use a new helper
find_existing_release() function, but the only effective change is that
the main release() function doesn't return early any more if a draft
release already exists.

This commit is best viewed ignoring whitespace-only changes and using
git --color-moved option.
    @vadz
    vadz committed Feb 9, 2023
    Configuration menu
    Copy the full SHA
    4c1f6af View commit details
    Browse the repository at this point in the history