Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Delete and recreate existing tag #175

Closed

Conversation

movermeyer
Copy link

@movermeyer movermeyer commented Oct 26, 2021

What are you trying to accomplish?

Fixes #149
Fixes #171
Resolves 2934fce#r58642151

Both of these are a result of the tag associated with the release not updating to match the new target_commitish.

What approach did you choose and why?

I added a boolean move_existing_tag flag that explicitly requests the deletion of the existing tag of an existing release.

This is opt-in, explicit behaviour, since most tags are considered to be immutable. However, some projects may decide that

What should reviewers focus on?

Assume that I have no idea what's going on.

I tried to research whether there was any problem with deleting lightweight tags, and everything I've found says that doing this is OK...

  • Tags are not part of the git log, so you don't have to rewrite history to delete them.

Deleting a lightweight tag is not such a big deal, but deleting an annotated tag, which is a bona fide Git object, should count as deleting local history.
-https://stackoverflow.com/a/25722673

WIP Status

  • Actually test it
    • Automated unit tests
    • Manual testing
  • We probably need to actually resolve the target_committish values to their SHAs and compare those?

The impact of these changes

Users will be able to opt into having update the commit that a tag points at as part of the release update.

Testing

Totally untested. WIP...

denibertovic added a commit to denibertovic/test-artifacts that referenced this pull request Nov 16, 2021
this doesn't work unil this is merged:
softprops/action-gh-release#175
@movermeyer movermeyer closed this Feb 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Release time does not update Allow for automatic nightly release
1 participant